From 346da00456eb20d41406a72e2e28f27429aca810 Mon Sep 17 00:00:00 2001 From: Keir Fraser Date: Mon, 19 Apr 2010 17:48:20 +0100 Subject: [PATCH] Synchronise lazy execstate before calling tasklet handlers. This ensures we are properly running on idle-vcpu state, which certain things (e.g., use of vmx_vmcs_{enter,exit}) rely on. It also means we don't need to do the same thing in the stopmachine_run handler. Signed-off-by: Keir Fraser --- xen/common/stop_machine.c | 2 -- xen/common/tasklet.c | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/common/stop_machine.c b/xen/common/stop_machine.c index 99604cde32..9f5dd1e799 100644 --- a/xen/common/stop_machine.c +++ b/xen/common/stop_machine.c @@ -98,7 +98,6 @@ int stop_machine_run(int (*fn)(void *), void *data, unsigned int cpu) for_each_cpu_mask ( i, allbutself ) tasklet_schedule_on_cpu(&per_cpu(stopmachine_tasklet, i), i); - sync_local_execstate(); stopmachine_set_state(STOPMACHINE_PREPARE); local_irq_disable(); @@ -121,7 +120,6 @@ static void stopmachine_action(unsigned long unused) { enum stopmachine_state state = STOPMACHINE_START; - sync_local_execstate(); smp_mb(); while ( state != STOPMACHINE_EXIT ) diff --git a/xen/common/tasklet.c b/xen/common/tasklet.c index 1ee2758663..05665ebc5d 100644 --- a/xen/common/tasklet.c +++ b/xen/common/tasklet.c @@ -76,6 +76,7 @@ void do_tasklet(void) t->is_running = 1; spin_unlock_irq(&tasklet_lock); + sync_local_execstate(); t->func(t->data); spin_lock_irq(&tasklet_lock); -- 2.30.2